[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: kmail crashes reproduceably ! (mailinglist-magic.cpp)
From:       Don Sanders <sanders () trolltech ! com>
Date:       2001-04-18 13:41:23
[Download RAW message or body]

The message looks invalid to me (see p *message debug that dfaure did).

Looks like new code is the culprit. Specifically new code in 
KMMainWin::updateMessageMenu

        KMMessage* msg = mMsgView->msg();  // bad bad bad
        if ( !msg )
            return;

        QString name, value;
        QString lname = detect_list( msg, name, value );

specifically I question the line I marked with the //bad bad bad comment.
The message pointed to by the readerwindow is not necessarily valid, sorry 
this is not at all obvious. I guess this method should be removed from
kmreaderwin.h

  /** Returns the current message or NULL if none. */
  KMMessage* msg(void) const { return mMsg; }

BTW, any progress on fixing the crash when deleting an account while the 
precommand is in progress? Perhaps if someone tries to delete an account
while mail checking is in progress the should be given a "sorry can't delete
accounts while mail checking is in progress" error message. Or better yet 
mark the current account being checked, and prevent that from being deleted.

BFN,
Don.

> Actually I have similiar crashes. But as you can see the message looks
> quite valid, so the problem must be somewhere else and it works before some
> other changes, so I'm not really sure it's mailinglist-magic is guilty. I'm
> going to try purify later this afternoon :)

> > (gdb) p message
> > $1 = (KMMessage *) 0x8b5f938
> > Current language:  auto; currently c++
> > (gdb) p *message
> > Cannot access memory at address 0x9f2cfd2
> > (gdb) bt
> > #0  0x08175f4b in check_sender (message=0x8b5f938, header_name=@0xbfffe958,
> > header_value=@0xbfffe950) at
> > ../../../kdenetwork/kmail/mailinglist-magic.cpp:11
> > #1  0x08176a57 in detect_list (message=0x8b5f938, header_name=@0xbfffe958,
> > header_value=@0xbfffe950) at
> > ../../../kdenetwork/kmail/mailinglist-magic.cpp:146
> > #2  0x0808b483 in KMMainWin::updateMessageMenu (this=0x81ac758)
> >     at ../../../kdenetwork/kmail/kmmainwin.cpp:2015
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]