[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: PATCH : scoring, take 2.1
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-04-16 13:29:14
[Download RAW message or body]

On Monday, 16. April 2001 12:00, Guillaume Laurent wrote:
>
> Mmh, where ? In KMScorableArticle ?

Right.

Im not completely sure, since some operation are faster with a QString than 
with a QCString, but I think it's worth a try.

> Quite strange. Given the debug messages, you should at least see some
> messages with a non-0 score. I had that problem at some point because after
> setting the score I wouldn't call irefresh() on the KMHeaderItem. Could it
> be that the recent speedup patch would have broken this ?

Actually if I check the option to display the message size the score is 
indeed displayed. I think that hint should help. If I check this option 
however I get two "Score" columns as long as I don't switch to a different 
folder.

> > The score dialog still has a few bugs, but they are probably in
> > libkdenetwork.
>
> I may still try to look at them and check with Mathias Waack.

At least this problem that the value of for example the pattern is not saved 
when changed and clicking Ok afterwards persists.

For the value a single click in enough to be able to edit it whereas the 
pattern field requires a double click.

On Monday, 16. April 2001 13:10, Guillaume Laurent wrote:
> This version checks if there are any rules for the current folder. I've
> also committed a couple of changes to support this in libkdenetwork, so
> you'll have to update that part as well.

This part seems to work well now, regarding the speed.

Since the size is displayed right aligned, I think the score should be 
displayed also that way.

Another Problem: Subfolders don't seem to work correctely. Also I have a rule 
defined that should only score the folder "KDE-cvs" but it does also score 
the folder "KDE-cvs.1". I think you should use KMFolder::idString.

Also some problems I mentioned in earlier posts are still present.

Regards,
Michael Häckel

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]