[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] a bit of filter dialog cleanup and extension - tested!(was: untested)
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-04-08 7:53:42
[Download RAW message or body]

On Saturday,  7. April 2001 21:49, Marc Mutz wrote:
>
> > And the name of a filter rule can now be edited. I still don't see a real
> > purpose of this feature.
>
> Well, I have quite a few rules in my netscape filter dialog and I
> personally like to name them after the ml or the person they filter on.

At least I think, that the automatic naming does the job very well and I 
consider it unneccessary time wasting, if I have to invent a name for every 
filter rule now, only because a few users absulutely want their own names. 
And I have a lot of filter rules. Only because Netscape allows naming of 
filter rules is for me no argument, that this feature is also required in 
KMail. If you really want to allow changing the name, then the automatic 
naming should still work, as long the user does not change the name manually.
Also I think, I'm not the only one with this opinion on this list, as this 
issue was discussed some months ago.

> > Also, at least the way it currently works I cosider it a bad design,
> > because if I first define a rule "From contains John@Doe.com" and then
> > change it to "From contains John.Doe@gmx.net" the name of the rule is
> > still
> > "<From>:John@Doe.com" which is surely more confusing than before.
>
> I see the point. But I think that one should not invest too much into
> backwards-compatibility. I think with proper labelling (still to come)
> the user will be well aware that it's now up to him to name the filters.
> The more so as for the normal user this change will arrive with other
> changes (e.g. IMAP).

At least I am of a different opinion here. Backwards compatibility is very 
important and if there is no really very good reason to break it, it should 
be kept. At least if it should come at a point, where all upgrading users 
will loose their filter rule configuration and have to define them again, I 
consider that change unacceptable.

And as you mention IMAP, it has already arrived in CVS and there is no 
backwards incompatible change. Not even a single new menu item was invented 
for that. Users that don't use IMAP only see a new third option in the 
account configuration which leads to a new dialog.

From your screenshot, I think, the layout is good, the same more and fewer 
buttons should then be there for the action, I guess. If you are unsure, how 
to do something, a screenshot is probably really better than a patch in this 
case.

Regards,
Michael Häckel

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]