[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Bug#20716: Kmail threading broken if Message-ID is missing
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-02-23 21:27:30
[Download RAW message or body]

On Tuesday, 20. February 2001 20:59, chaotica@home.se wrote:
> Package: kmail
> Version: KDE 2.1.0 CVS/CVSup/Snapshot
> Severity: normal
> Installed from:    Compiled sources
> Compiler:          gcc 2.96
> OS:                Linux
> OS/Compiler notes: Red Hat
>
> Messages with missing Message-ID headers are threaded even if they are
> unrelated (no references or in-reply-to headers).
>
> Suggestion: if missing, generate a fake Message-ID composed of a hash of
> sender address and date, or something similar not likely to generate
> duplicates.

That doesn't really make sense IMHO.
Nevertheless fixed in CVS.

Regards,
Michael Haeckel

diff -u -3 -p -r1.232 kmheaders.cpp
--- kmheaders.cpp       2001/02/23 16:11:38     1.232
+++ kmheaders.cpp       2001/02/23 21:22:13
@@ -1903,7 +1903,7 @@ kdDebug() << "mFolder->count() = " << mF
       if (*mTreeToplevel[msgId] && !mItems[i]) {
        KMHeaderItem* hi = new KMHeaderItem( this, mFolder, i, &mPaintInfo );
        mItems[i] = hi;
-       recursivelyAddChildren( i, hi );
+       if (!msgId.isEmpty()) recursivelyAddChildren( i, hi );
       }
     }
_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]