Your message dated Wed, 29 Nov 2000 17:27:08 +0100 with message-id <00112917181700.00863@michael> and subject line Bug#16244: patch: reply to multipart/alternative when main part has no charset defined has caused the attached bug report to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what I'm talking about this indicates a serious mail system misconfiguration somewhere. Please contact me immediately.) Stephan Kulow (administrator, KDE bugs database) Received: (at submit) by bugs.kde.org; 29 Nov 2000 13:39:37 +0000 Received: (qmail 15688 invoked from network); 29 Nov 2000 13:39:37 -0000 Received: from mailout06.sul.t-online.com (194.25.134.19) by max.tat.physik.uni-tuebingen.de with SMTP; 29 Nov 2000 13:39:37 -0000 Received: from fwd03.sul.t-online.com by mailout06.sul.t-online.com with smtp id 1417SO-0006EE-07; Wed, 29 Nov 2000 14:39:32 +0100 Received: from poboxes.com (320056291824-0001@[62.158.234.147]) by fmrl03.sul.t-online.com with esmtp id 1417SA-0ylG1wC; Wed, 29 Nov 2000 14:39:18 +0100 Received: from verilin (verilin.verisoft.ch [192.168.1.99]) by poboxes.com (Postfix) with SMTP id 5492C3F8C3 for ; Wed, 29 Nov 2000 14:39:16 +0100 (CET) Subject: patch: reply to multipart/alternative when main part has no charset defined From: Wolfgang Rohdewald To: submit@bugs.kde.org Message-Id: <20001129133916.5492C3F8C3@poboxes.com> Date: Wed, 29 Nov 2000 14:39:16 +0100 (CET) X-Sender: 320056291824-0001@t-dialin.net Package: kmail Version: 1.2 (KDE 2.0.9 >= 20001128) Severity: normal Compiler: gcc version 2.95.2 19991024 (release) OS: Linux 2.2.16 i686 (compiled sources) I have a multipart/alternative message which does not define a charset in the main headers, but the message part does. The charset of the message part is not used by KMMessage::asQuotedString. This patch uses the charset of the part if and only if the main headers don't define it. Problem (why I found this): IF codecForLocale() is used, the umlauts appear rather strangely in the quoted text. The UTF-8 codec is used. An a umlaut ( and the next char become =EF=BF=N^H=BD (quoted-printable) or ? (8bit) Why ? I suspect this is a known problem. --- ../kmail.org/kmmessage.cpp Wed Nov 29 14:19:32 2000 +++ kmmessage.cpp Wed Nov 29 14:21:31 2000 @@ -619,6 +619,13 @@ isInline = (stricmp(msgPart.contentDisposition(), "inline") == 0); if (isInline) { + if (cset.isEmpty() || cset.isNull()) { + cset = msgPart.charset(); + if (!cset.isEmpty() && !cset.isNull()) + codec = KGlobal::charsets()->codecForName(charset()); + else + codec = QTextCodec::codecForLocale(); + } if (stricmp(msgPart.typeStr(),"text") == 0 || stricmp(msgPart.typeStr(),"message") == 0) { Kpgp* pgp = Kpgp::getKpgp(); _______________________________________________ Kmail Developers mailing list Kmail@master.kde.org http://master.kde.org/mailman/listinfo/kmail