[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Bug#16072: patch for trailing garbage in kmreaderwin
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2000-11-28 15:54:12
[Download RAW message or body]

On Tuesday, 28. November 2000 01:48, you wrote:
>
> This patch activated another latent bug in
> kmcomposewin::applyChanges: If I forward and GPG sign a message with
> attachment, this bug removed the last LF of the string END PGP SIGNATURE
> Result: Kpgp::setMessage did not find this string.
>     // begin the search for the next '\n' after "-----END PGP"
>     index = mess.find("\n",index+13);
>     back  = mess.right(mess.length() - index); // index is -1 since LF
> missing
>
> Result: The text appears twice. Example in Mail "Fwd: Fax..." in attached
> file. The buggy code removed the last char (the LF) by shortening the
> string by 1 char. But the LF was still there - until my patch explicitly
> puts a HEX 00 there. I fixed that too.

But you removed my bugfix for the problem, that a mail with attachment and 
encoding for the text part quoted printable (switchable in the configure 
dialog) has a =00 at the end of the body part.

The bug must be somewhere else in your patch. At least this double text 
problem does not appear without it.

Regards,
Michael Häckel

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]