[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: kab interaction problem
From:       Don Sanders <sanders () kde ! org>
Date:       2000-11-02 13:44:24
[Download RAW message or body]

I fixed a problem in kmaddrbook.cpp a couple days ago (in CVS). As a side 
effect it also seems to have fixed this bug. I attach the change.

BFN,
Don.

On Tuesday 31 October 2000 22:45, Mike Davison wrote:
> Ok, after some digging I've found something. If kmail is set to use kab,
> addressses saved from kmail (right click on address and select 'add to
> address book') will have the problem I described. Yet, if kmail is
> configured to use abbrowser, saved addresses will not have the problem. The
> difference is that when abbroswer is used the 'emails' field gets just the
> e-mail address whereas when kab is used the 'emails' field gets 'name
> name@domain'.  Kmail latter chokes on that format. For example:
>

["aliases.diff" (text/plain)]

Index: kmaddrbook.cpp
===================================================================
RCS file: /home/kde/kdenetwork/kmail/kmaddrbook.cpp,v
retrieving revision 1.26
diff -u -b -r1.26 kmaddrbook.cpp
--- kmaddrbook.cpp	2000/08/17 20:49:38	1.26
+++ kmaddrbook.cpp	2000/10/28 11:52:36
@@ -189,6 +189,7 @@
 void KabBridge::addresses(QStringList* result, QValueList<KabKey> *keys)
 {
   QString addr;
+  QString email;
   KabKey key;
   AddressBook::Entry entry;
   if (keys)
@@ -207,7 +208,13 @@
 	addr = "";
       else
 	addr = "\"" + entry.fn + "\" ";
-      addr += "<" + entry.emails[0] + ">";
+      email = entry.emails[0];
+      if (!addr.isEmpty() && (email.find( "<" ) == -1)
+	  && (email.find( ">" ) == -1)
+	  && (email.find( "," ) == -1))
+	  addr += "<" + email + ">";
+      else
+	  addr += email;
       addr.stripWhiteSpace();
       result->append( addr );
       if (keys)

_______________________________________________
Kmail Developers mailing list
Kmail@master.kde.org
http://master.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]