[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Unicode changes breaks attachment viewing
From:       Don Sanders <sanders () kde ! org>
Date:       2000-08-31 14:22:08
[Download RAW message or body]

On Thu, 31 Aug 2000, Michael Haeckel wrote:

> > Hi,
>
> Always I select RMB->View... on a text attachment like the attached one,
> KMail crashes. The problem is not present in my compiled version of KMail
> from two days ago. And I was looking for an error in my attachment viewing
> patch :-( Backtrace this time attached.

Oh, sorry about wasting your time. The following change to kmreaderwin works 
around the problem (for some reason mCodec is null), but I'll have to spend a 
bit more time on it to find out what the best solution is:

@@ -851,7 +851,11 @@
     str = pgp->backmatter();
     if(!str.isEmpty()) htmlStr += quotedHTML(str);
   }
-  else htmlStr += mCodec->toUnicode(quotedHTML(aStr));
+  //  else htmlStr += mCodec->toUnicode(quotedHTML(aStr));
+  else if (mCodec)
+      htmlStr += mCodec->toUnicode(quotedHTML(aStr));
+  else
+      htmlStr += quotedHTML(aStr);
   mViewer->write(htmlStr);
 }

BFN,
Don.

[prev in list] [next in list] [prev in thread] [next in thread]