[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Bug 7229 again...sorry
From:       Waldo Bastian <bastian () kde ! org>
Date:       2000-08-24 23:50:35
[Download RAW message or body]

On Thu, 24 Aug 2000, Mark Roberts wrote:
> Hi,
>
> I see that bug 7229 was discussed from 2nd to 5th of August. I have a
> similar problem.
>
> To be clear, bug 7229 was that because the account name of a POP3 account
> has to comply with the standard for URLs, it was impossible to retrieve
> mail from GMX. The solution appears to be that the bug reporter changed the
> user name format and was able to get around it. It appears to be that no
> one thought it was a bug.
>
> I have an account at taurine@genie.co.uk which cannot be logged in to with
> a different user name by POP3. KMail 1.0.29.2 didn't have a problem with
> this, but the 1.1.90 does have this problem. I have looked at the source
> and found the reason for the problem, a few lines in kmacctexppop.cpp:
>
> if (mUseSSL) {
>     text = "spop3://" + mLogin + ":" + decryptStr(mPasswd) + "@" +
>             mHost + ":" + QString("%1").arg(mPort) + "/index";
>   } else {
>     text = "pop3://" + mLogin + ":" + decryptStr(mPasswd) + "@" +
>             mHost + ":" + QString("%1").arg(mPort) + "/index";
>   }
>   KURL url = text;
>   if ( url.isMalformed() ) {
>     QMessageBox::critical(0, i18n("Kioslave Error Message"),
> 			  i18n("Source URL is malformed") );
>     return;
>   }

The above code is incorrect. It should use KURL to build a URL and use the
setProtocol, setUser, setPassword, etc. functions.

A quick&dirty fix would be to replace "mLogin" and "decryptStr(mPasswd)"
with KURL::encode_string(mLogin) and KURL::encode_string(decryptStr(mPasswd))

Cheers,
Waldo
-- 
KDE/Linux, made for people, made by people.

[prev in list] [next in list] [prev in thread] [next in thread]