[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    patches (window size; wishlost item)
From:       Daniel Naber <dnaber () mini ! gt ! owl ! de>
Date:       2000-04-23 22:36:44
[Download RAW message or body]

Hi,

here's one simple patch that gives the "View source" window a better size.

The other patch fulfils bug (wishlist) #2920, at least the To/Cc part. I never
saw "X-BeenThere" before, so I didn't implement it (it would be a one line 
change anyway).

Can anybody check if the use of i18n() is correct in this patch? In the old 
code, in one file i18n() was used and (for the same string) in another file, 
it wasn't (probably a bug introduced by me). 

Uhm, Don, can you apply? Thanks.

Regards
 Daniel

["filter-to-or-cc.diff" (text/plain)]

--- kmfilterdlg.cpp.org	Sun Apr 23 23:14:31 2000
+++ kmfilterdlg.cpp	Mon Apr 24 00:11:40 2000
@@ -682,9 +682,11 @@
   if (sFilterFieldList.count() <= 0)
   {
     sFilterFieldList.append(" ");
+    // also see KMFilterRule::matches() if you change the following strings!
     sFilterFieldList.append(i18n("<message>"));
     sFilterFieldList.append(i18n("<body>"));
     sFilterFieldList.append(i18n("<any header>"));
+    sFilterFieldList.append(i18n("<To or Cc>"));
     sFilterFieldList.append("Subject");
     sFilterFieldList.append("From");
     sFilterFieldList.append("To");
--- kmfilter.cpp.org	Sun Apr 23 16:36:51 2000
+++ kmfilter.cpp	Mon Apr 24 00:18:25 2000
@@ -302,17 +302,21 @@
   QString msgContents;
 
   assert(msg != NULL); // This assert seems to be important
-  
-  if( mField == "<message>" ) {
-           // there's msg->asString(), but this way we can keep msg const (dnaber, 1999-05-27)
-           msgContents = msg->headerAsString();
-           msgContents += msg->bodyDecoded();
-         } else if( mField == "<body>" ) {
-           msgContents = msg->bodyDecoded();
-         } else if( mField == "<any header>" ) {
-   msgContents = msg->headerAsString();
+
+  if( mField == i18n("<message>") ) {
+    // there's msg->asString(), but this way we can keep msg const (dnaber, 1999-05-27)
+    msgContents = msg->headerAsString();
+    msgContents += msg->bodyDecoded();
+  } else if( mField == i18n("<body>") ) {
+    msgContents = msg->bodyDecoded();
+  } else if( mField == i18n("<any header>") ) {
+    msgContents = msg->headerAsString();
+  } else if( mField == i18n("<To or Cc>") ) {
+    msgContents = msg->headerField("To");
+    msgContents += "\n";
+    msgContents += msg->headerField("Cc");
   } else {
-  msgContents = msg->headerField(mField);
+    msgContents = msg->headerField(mField);
   }
 
   switch (mFunction)

["view-source-size.diff" (text/plain)]

--- kmmessage.cpp.org	Sat Apr 22 21:39:13 2000
+++ kmmessage.cpp	Sat Apr 22 21:39:30 2000
@@ -1631,6 +1631,8 @@
 
   edt->insertLine(str);
   edt->setReadOnly(TRUE);
+  edt->resize(KApplication::desktop()->width()/2, 2*KApplication::desktop()->height()/3);
+  edt->setCursorPosition(0, 0);
   edt->show();
 
 #else //not ALLOW_GUI


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic