-----BEGIN PGP SIGNED MESSAGE----- On Wed, 09 Feb 2000, Andreas Gungl wrote: This looks fine to me but I can't test it (other than compiling it) because PGP is not installed on my dev machine and I don't have time to install it at the moment. Can someone else commit this patch (or did someone else commit it already)? Unfortunately I still can't get developing for a while. I slept a total of 20 hours this week so far. I'm in bad shape :) I still have much too much work to do too. *maybe* I'll get some free time around Monday, but if not, I'll probably be absent until the end of the month. > Some time ago George has reported about a problem, when he had typed > in his passphrase to sign a message and pressed ESC to abort. Since > the passphrase was correct, kmail signed his message and sent it. > > I'ld suggest the following correction in kpgp.cpp: > > QString > KpgpPass::getPassphrase(QWidget *parent) > { > KpgpPass kpgppass(parent, i18n("OpenPGP Security Check")); > if (kpgppass.exec()) > return kpgppass.getPhrase().copy(); > else > return QString::null; > } > > OLD: > kpgppass.exec(); > return kpgppass.getPhrase().copy(); > > NEW: > if (kpgppass.exec()) > return kpgppass.getPhrase().copy(); > else > return QString::null; > > So the phrase wonīt become returned, when a user hits ESC in the > dialog. The result should be a "wrong" (invalid) phrase and kmail > will wait for a new user action - without processing of the message, > which will remain in the composer window. > > Although Iīve tested this code, it would be nice if somebody else > could do so. And since I didnīt prepare cvs acces, could someboy > apply this patch, after it is verified? - -- George Staikos -----BEGIN PGP SIGNATURE----- Version: PGP 6.5.2 iQEVAwUBOKRk5vaardfOEhQRAQH/egf/Qt2LjLFBOP9JgxFLh5xFhKClwO3j8nU6 o5c+Ut83ZW8b2uPNGFygBSWberczsNQhs1hGjLby7eoXN4z/uSsABnfO2jz7v9hF /ZL9hVv0U9bNCi0HvIpQsKhD2IwZsrL6vdYelsKnQlO/MhRPYFXfVwM0cFNDdYC0 K/8pzavGwAi75PC3TubTWK9cTuHTJC1/jLE4sIM9lhZt0j4OKUQCjVczxDAVlqHH gH+Zmb9QP2hNfHIIvKJrnyZJ4VMG3UgXviRsO3UF21IuSFDWj05CYDMvuFVO3MMf AgMKcFwkBo8oEzHnMzIhN9U+K3xNPSdcP9KX+cjMHjUOaV4tQbDwhg== =sQZ1 -----END PGP SIGNATURE-----