[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Bug 129034] {PATCH] JJ: URL in gnupg "Password Dialog" not
From:       Eugeniu Plamadeala <eugen.plamadeala () gmail ! com>
Date:       2007-08-17 19:53:52
Message-ID: 200708171253.58716.eugen.plamadeala () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi!

Alright, I removed that comment. 
I also removed a line which now is superfluous.
It inserted a "<qt>" at the beginning of the message because the 
KPasswordDialog needed a "<" in order to display it correctly.

My patch for KPasswordDialog got accepted, so it displays things nicely now 
without "<".

On Friday 17 August 2007 09:47:40 Thomas McGuire wrote:
> http://bugs.kde.org/show_bug.cgi?id=129034
> Thomas.McGuire gmx net changed:
>
>            What    |Removed                     |Added
> ---------------------------------------------------------------------------
>- Summary|JJ: URL in gnupg "Password  |{PATCH] JJ: URL in gnupg
>
>                    |Dialog" not clickable       |"Password Dialog" not
>                    |
>                    |                            |clickable
>
> ------- Additional Comments From Thomas.McGuire gmx net  2007-08-17 18:47
> ------- You should also remove the "add #gnupg2 if you can make this a real
> link" comment now.
>
> Anyway, get your KPasswordDialog patch accepted first, then this one can go

-- 
Best regards,
  Eugeniu

************************
eugen.plamadeala@gmail.com
www.plamadeala.com
PGP Key ID: 0x486EA33F
************************

["qgpgmejob.diff" (text/x-diff)]

--- qgpgmejob.cpp	2007-08-16 16:00:20.000000000 -0700
+++ qgpgmejob2.cpp	2007-08-17 12:25:56.000000000 -0700
@@ -258,7 +258,6 @@
                 i18n( "You need a passphrase to unlock the secret key for user:<br/> \
%1",  QString::fromUtf8( useridHint ) );
   msg += "<br/><br/>";
-  msg.prepend( "<qt>" );
   msg += i18n( "This dialog will reappear every time the passphrase is needed. For a \
more secure solution that also allows caching the passphrase, use gpg-agent." ) + \
"<br/>";  const QString gpgAgent = KStandardDirs::findExe( "gpg-agent" );
   if ( !gpgAgent.isEmpty() ) {
@@ -267,11 +266,11 @@
   } else {
     msg += i18n( "gpg-agent is part of gnupg-%1, which you can download from %2" ,
              QString("1.9") ,
-             QString("http://www.gnupg.org/download") );  // add #gnupg2 if you can \
make this a real link +             QString("<a \
href=\"http://www.gnupg.org/download#gnupg2\">gnupg.org</a>") );  }
   msg += "<br/>";
   msg += i18n( "For information on how to set up gpg-agent, see %1" ,
-           QString("http://kmail.kde.org/kmail-pgpmime-howto.html") );
+           QString("<a \
href=\"http://kmail.kde.org/kmail-pgpmime-howto.html\">http://kmail.kde.org/kmail-pgpmime-howto.html</a>") \
);  msg += "<br/><br/>";
   msg += i18n( "Enter passphrase:" );
   KPasswordDialog dlg;


["signature.asc" (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]