[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Reason for crashes when filtering mails
From:       Allen Winter <winter () kde ! org>
Date:       2007-02-25 16:43:49
Message-ID: 200702251143.50118.winter () kde ! org
[Download RAW message or body]

On Sunday 25 February 2007 9:21:34 am Andreas Gungl wrote:
> Am Sonntag, 25. Februar 2007 schrieb Allen Winter:
> > On Sunday 25 February 2007 7:39:38 am Andreas Gungl wrote:
> > > Hello,
> > >
> > > starting with KMail from KDE 3.5.6 I often get crashes when filtering
> > > many messages in a folder manually (applying all filters).
> > > The problem goes down to the following lines in kmfolder.cpp:
> >
> > [..snip..]
> >
> > > Well, if someone can comment on this, I'd like to fix it the right way.
> >
> > I nagged it earlier on this list, and even provided a patch which is
> > attached to http://bugs.kde.org/show_bug.cgi?id=140660
> >
> > So far nobody has commented, and nobody else has tried my patch AFAIK.
> > If you are using the KMail from pim+, then you are using my patch.
> >
> > Please search for the message "About BR 140660" which may
> > be in your mailbox for other info.
> 
> Allen, I've had a quick look at your changes. I'm running the 3.5 branch.
> 
> The index range is not clear to me. Is 0 (zero) a valid index like in arrays? 
No idea.

> I've seen you skipping idx == 0 in some places which looks strange. If 0 is 
> not allowed, why is -1 used to indicate a failing find() ?
>
No, I see tests for idx >= 0 in my patch only.
So it makes sense to me that -1 indicates a find failure.
 
> After applying your changes in kpim+ to my sources, I've got problems to 
> filter the last message in a folder. I've simply moved some spam messages 
> into a new folder. Then I expected them being filtered back into the spam 
> folder. One message remains. And it is unselected and the preview pane is 
> empty.
>
Don't know. 

> So I think this is an improvement, but not a real solution.
>
Yeah.
There are many places where we assert(idx).


-- 
KDEPIM Developer
I accept PayPal payments to awinterz@earthlink.net
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]