From kmail-devel Sun Feb 25 14:21:34 2007 From: Andreas Gungl Date: Sun, 25 Feb 2007 14:21:34 +0000 To: kmail-devel Subject: Re: Reason for crashes when filtering mails Message-Id: <200702251521.35039 () gungl-dd ! de> X-MARC-Message: https://marc.info/?l=kmail-devel&m=117241330523600 Am Sonntag, 25. Februar 2007 schrieb Allen Winter: > On Sunday 25 February 2007 7:39:38 am Andreas Gungl wrote: > > Hello, > > > > starting with KMail from KDE 3.5.6 I often get crashes when filtering > > many messages in a folder manually (applying all filters). > > The problem goes down to the following lines in kmfolder.cpp: > > [..snip..] > > > Well, if someone can comment on this, I'd like to fix it the right way. > > I nagged it earlier on this list, and even provided a patch which is > attached to http://bugs.kde.org/show_bug.cgi?id=140660 > > So far nobody has commented, and nobody else has tried my patch AFAIK. > If you are using the KMail from pim+, then you are using my patch. > > Please search for the message "About BR 140660" which may > be in your mailbox for other info. Allen, I've had a quick look at your changes. I'm running the 3.5 branch. The index range is not clear to me. Is 0 (zero) a valid index like in arrays? I've seen you skipping idx == 0 in some places which looks strange. If 0 is not allowed, why is -1 used to indicate a failing find() ? After applying your changes in kpim+ to my sources, I've got problems to filter the last message in a folder. I've simply moved some spam messages into a new folder. Then I expected them being filtered back into the spam folder. One message remains. And it is unselected and the preview pane is empty. So I think this is an improvement, but not a real solution. Andreas -- Kindermode Online - Fashion for Kids http://www.theofeel.de _______________________________________________ KMail developers mailing list KMail-devel@kde.org https://mail.kde.org/mailman/listinfo/kmail-devel