[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Memory usage (Re: QCString construction)
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2007-02-22 21:07:24
Message-ID: 200702222207.29061 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 22 February 2007 12:18, David Faure wrote:
> On Monday 19 February 2007, Ingo Klöcker wrote:
> > I thought you wanted to write
> > KMMessage msg( new DwMessage( this->mMsg ) );
>
> Doh! Somehow I lost track of that. Thanks.
> Actually it's KMMessage msg( new DwMessage( *this->mMsg ) );
>
> In the general case (for code outside of KMMessage), it looks like
> this though: KMMessage* msgCopy = new KMMessage( new DwMessage(
> *msg->asDwMessage() ) ); which reads very strange/unusual... (the
> nested new calls)
> But it does what we need so I'm ok with it, I'm just wondering about
> future readers of the code :)
>
> The patch is attached. Seems to work here; bcc is preserved in
> sent-mail copy.

The patch looks good.

> In my testing I noticed one strange behavior: inline-forwarding an
> HTML-only mail leads to html tags in the body of the composer window,
> but I think this is unrelated to my changes.

That's by design. If the HTML message is viewed as HTML then the HTML is 
converted to text, but if the HTML message is viewed as plain text then 
the plain text is forwarded.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]