[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: URL grabbing bugfix
From:       Jonathan Marten <jjm () keelhaul ! demon ! co ! uk>
Date:       2006-10-31 14:26:00
Message-ID: ovfyd4d0jr.fsf () keelhaul ! local
[Download RAW message or body]

David Faure <dfaure@klaralvdalens-datakonsult.se> writes:
> On Tue Oct 31 2006, Jonathan Marten wrote:
>> I'd like to commit a fix to the features branch for
>> http://bugs.kde.org/show_bug.cgi?id=81281 and
>> http://bugs.kde.org/show_bug.cgi?id=104749.  Both of them need to
>> extend the allowed characters in a URL so that a trailing "-" or "_"
>> is accepted.  The fix is in LinkLocator::getUrl() in
>> libkdepim/linklocator.cpp
>
> As a side note, I wonder why this doesn't use
> KStringHandler::tagUrls() from kdelibs/kdecore instead.

Good point, although using that would be more that just a 1-line
change.  Unfortunately the regexp used there wouldn't fix the URLs in
these cases, because the last character must match '[\\d\\w/]'.

-- 
Jonathan Marten                         http://www.keelhaul.demon.co.uk
Twickenham, UK                          jjm@keelhaul.demon.co.uk
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]