From kmail-devel  Fri Sep 29 20:58:32 2006
From: Carsten Pfeiffer <pfeiffer () kde ! org>
Date: Fri, 29 Sep 2006 20:58:32 +0000
To: kmail-devel
Subject: Re: Address completion (Re: Duplicates)
Message-Id: <200609292258.35079.pfeiffer () kde ! org>
X-MARC-Message: https://marc.info/?l=kmail-devel&m=115956353601366
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1095210940=="

--===============1095210940==
Content-Type: multipart/signed;
  boundary="nextPart15287259.hBDMt0Yfhs";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart15287259.hBDMt0Yfhs
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Hiya,

(David brought this thread to my attention -- I'm not subscribed to=20
kmail-devel anymore, so please CC: me and forgive me the thread-destruction=
=20
(can you add custom References: headers to kmail?))

> > but then all the matches will be lower case as well ...
> > there must be an other way...
>
> Fix KCompletion.ignoreCase. :-)

KCompletion only performs the *matching* case insensitively, the matches=20
themselves are kept and returned in their original case.

> Great. And thanks for the explanation. The code really seems to be
> rather complicated. Maybe we should throw a Marc Mutz on the original
> developers to teach them about the Strategy pattern.

Thanks for the offer, but I already know about design patterns :-)=20

A strategy wouldn't really help here, because this is not about different=20
strategies for the same thing (i.e. the same interface) -- makeCompletion=20
with CompletionAuto returns just one string, substringCompletion() and=20
allMatches() return multiple matches. These are just different things, that=
=20
need to be dealt with differently.

I'm not denying that KCompletion couldn't be improved though, with today's=
=20
requirements for completion in mind, that haven't been anticipated back the=
n.

Cheers,
Carsten

--nextPart15287259.hBDMt0Yfhs
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----

iQEVAwUARR2I+6WgYMJuwmZtAQIZIQgAk7rablIesqziUgpgNeQhJ58t4VxiubNy
90iRolh3A4trgYQGU1ho5SL/6IvZ0gUOWycpWS28upqXydMd0TqW75tvi/Pe+s8c
AXClUX4grOtAFAAwR378hyl1CTGR7/lmK4iflZ1o0SXbQg9/JnTE5Ek2TAR+++lv
xFEkKn4Qcu1LLLmE3/5AHrUzEtN3SBUQk8PZP8L86H/dIM6N6qbFttB6USpefTpy
GZXnf3KAu2c7TJZ7+8dPL4cjoiXYFgahiHpZLcXvEstZ0jO1LLIvZ0qTrWiD67eZ
1KooGdgUEzEs7FyMKrYEQnz1zTK91O+nmH40xkuJTWgJOnMxZDWhnQ==
=M4vI
-----END PGP SIGNATURE-----

--nextPart15287259.hBDMt0Yfhs--

--===============1095210940==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

--===============1095210940==--