'[PATCH] Re: Tagging in kmail...'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [PATCH] Re: Tagging in kmail...
From:       Ismail Onur Filiz <onurflz () yahoo ! com>
Date:       2006-03-01 1:00:25
Message-ID: 200602281700.26028.onurflz () yahoo ! com
[Download RAW message or body]

Hello again,
In the meantime, I worked on this feature more. I added the ability to 
configure the set of tags. There is a new tab "Message Tags" in the 
"Appearance" configuration page. 

With this patch, you can:
- Place tag togglers into the toolbar.
- Assign shortcuts
- Change the importance order of tags
- Choose the text color and font
- There are entries in the right-click and main menus, under "mark message as" 
submenu.

The address to download the patch is:
http://www.ieor.berkeley.edu/~onurf/kmail.tagging.0.2.2.patch

It is in a quite usable state. Please give me feedback about it. And don't 
forget to backup your mail directory before trying if you try it.

Kmail maintainers, could you comment on the possibility of merging this 
feature into the 4.0 release?

Now on to details: It applies to version 3.5.1 of the KDE branch. The list of 
files it modifies is:

configuredialog.cpp  
headeritem.h    
kmail_part.rc        
kmheaders.h   
kmmainwidget.cpp  
kmmainwin.rc   
kmmsgbase.cpp  
kmmsginfo.h   
Makefile.am
configuredialog_p.h  
kmfoldermaildir.cpp  
kmkernel.cpp  
kmmainwidget.h    
kmmessage.cpp  
kmmsgbase.h    
headeritem.cpp      
kmail_part.cpp  
kmheaders.cpp        
kmkernel.h    
kmmainwin.cpp     
kmmessage.h    
kmmsginfo.cpp  

I know that the list is long, but most of the changes are few liners. It also 
adds the following two files:

kmmsgtag.cpp
kmmsgtag.h

The only "problem" with the current patch I found was, if you change the order 
of tags, you need to change the folder and come back to update the view. I 
know the reason for it, but fixing it is not worth the change it requires.

I still need to work on changing the background color and some more features I 
have in mind.

Thanks for your feedback.

Best...

On Thursday 23 February 2006 12:17, Ismail Onur Filiz wrote:
> Hi again,
> The patch right now is not in mergeable state anyhow. It is preliminary
> work. (If you do configuration by hand it works though) My main intention
> actually was what you described, get the approval from the maintainers. I
> also wanted to verify that I am doing things the right way, putting
> functions in right places etc. Also I have a few more features related to
> tagging that I want to implement later on.
>
> I am aware that the feature freeze is on, so it is OK that this feature
> stays as a patch until 4.0 is out.
>
> I also wanted to ask whether there is a particular reason for filter
> configurations not being inside "Configure KMail..." dialog. It is relevant
> since I am trying to decide where to plug the "tag configuration widgets"
> into, and the layout of the configuration of a tag will be similar to that
> of a filter. The alternatives are a seperate entry in the settings menu
> item, another page in the main configuration, another tab in the Appearance
> or Misc pages.
>
> Thank you for your support and encouraging reply Allen.
>
> Best...
> Onur
>
> On Thursday 23 February 2006 08:04, Allen Winter wrote:
> > Ismail,
> >
> > Thanks for all your work.
> > I will be looking at your patch sometime soon, but please be aware that
> > we have a feature freeze in the 3.5.x release stream, and 4.0 is still a
> > long way off.
> >
> > Also, we will have to get the blessing from the KMail maintainers before
> > officially merging this feature into the 4.0 codebase.   But I think
> > customized tagging is a cool feature.
> >
> > Regards and thanks!
> > Allen
> >
> > On Wednesday 22 February 2006 08:16, Ismail Onur Filiz wrote:
> > > Hello everyone,
> > > As discussed in bugs 15391 and 50409. I am working on implementing
> > > tagging/color coding. I have done some coding throughout the last few
> > > days, and succeeded in implementing the framework. You can assign tags
> > > (possibly more than one, coloring is done via priority ordering) to the
> > > emails through the menus (no shortcuts as of now). Kmail creates three
> > > hardcoded tags with this patch, which one can theoretically augment by
> > > hand-editing the configuration file.
> > >
> > > I wanted to get your feedback / opinions on my work. You can download
> > > the patch from http://ieor.berkeley.edu/~onurf/kmail.tagging.0.1.patch
> > > . Your feedback will be greatly appreciated.
>
> _______________________________________________
> KMail developers mailing list
> KMail-devel@kde.org
> https://mail.kde.org/mailman/listinfo/kmail-devel
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread] 