[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Help needed for fixing bug 114985
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2005-11-23 15:29:19
Message-ID: 200511231629.25285 () gungl-dd ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Am Dienstag, 15. November 2005 21:14 schrieb Carsten Burghardt:
> To be honest I don't think we should allow moving of subfolders. I disabled
> it because it is too dangerous but as you confirmed the bug there is
> obviously a flaw. The code checks if the folder has subfolders and then
> _should_ disabled the function. If you enable this you have to make it work
> for all kinds of folders which also mean imap folders.

To give some detailed feedback: The Move Folder To menu item in the folder 
popup menu depends on the result of FolderStorage::isMoveable(). The method 
returns false for non-system folders with child folders if a folder in a 
dIMAP account is selected.
IMO it ever returns true for non-system folders in local accounts which is 
intended but partially wrong. Of course you can move nested folders from one 
local account to another. But then you should make sure that it's impossible 
to select any location in an (d)IMAP account if the folder has subfolders.

To fix that bug, I don't intend to enable anything which isn't enabled ATM. 
Instead I'll try to fix what is allowed currently as I consider it wasting 
time to extend the decision matrix for allowed folder movements.

Andreas

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]