[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Help needed for fixing bug 114985
From:       Carsten Burghardt <burghardt () kde ! org>
Date:       2005-11-15 20:14:21
Message-ID: 200511152114.21948.burghardt () kde ! org
[Download RAW message or body]

Am Tuesday 15 November 2005 18:08 schrieb Andreas Gungl:
> Hi,
>
> In the 3.5 branch, there I try to find a solution for
> http://bugs.kde.org/show_bug.cgi?id=114985 which in simple words means to
> care for subfolders during a move of a folder.
>
> I attach what I've implemented so far. However, I can't find a way to add a
> proper KMFolderDir to a folder when it has been moved to an dIMAP account.
> Can someone give me a hint?
> The problem is in RenameJob::slotMoveSubFolders where
> mNewFolder->createChildFolder(); creates a child which seems to have the
> standard type later on. Instead, it should have the CachedIMAP type.

To be honest I don't think we should allow moving of subfolders. I disabled it 
because it is too dangerous but as you confirmed the bug there is obviously a 
flaw. The code checks if the folder has subfolders and then _should_ disabled 
the function. If you enable this you have to make it work for all kinds of 
folders which also mean imap folders. Imagine you want to move a folder with 
several subfolders and several thousands of mails. Somewhere in between you 
have a network problem. I don't think you can really handle this case.
So the bugfix for the 3.5 branch is to check why these folders can be moved 
currently.


Carsten
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]