[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 115464] folder property "Keep replies in this folder" setting is
From:       Don Sanders <sanders () kde ! org>
Date:       2005-11-09 8:32:48
Message-ID: 20051109083248.18820.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=115464         
sanders kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From sanders kde org  2005-11-09 09:32 -------
On Thursday 27 October 2005 01:36, Allen Winter wrote:
> On Wednesday 26 October 2005 08:08, Martin Koller wrote:
> > On Friday 21 October 2005 22:40, Adriaan de Groot wrote:
> > > On Friday 21 October 2005 17:28, Allen Winter wrote:
> > > >  1. Kmail folder properties (esp. the Act on new/unread.. and
> > > > Keep replies) get set/reset strangely by themselves.
> > >
> > > Get this every time KMail is kill -TERM'ed, yup; most folders
> > > lose their 'act on new' setting. And kill -TERM happens often,
> > > because kmail hangs on me regularly and I haven't been able to
> > > track down why.
> >
> > I think I have a fix for this (attached).
> >
> > A little description of what I found:
> >
> > Whenever the folder-properties dialog is closed, writeConfig() is
> > called, which results in kmailrc only holding (for this folder)
> > the setting isOpen = true
> >
> > The rest of the setting are only stored to disk, when you change
> > to another folder.
> >
> > When now you kill kmail before the rest is written, then
> > obviously some defaults are used the next time ... (which means,
> > about 40 (!) settings are lost)
> >
> > isOpen = true is created from 
> > KMFolderTree::writeIsListViewItemOpen(..)
> >
> > I don't know how this whole KConfig stuff is supposed to work,
> > but what I did is, I added here a call to 
> > folder->storage()->writeConfig(); which is also done in the 
> > FolderDiaGeneralTab::save() method.
> >
> > I don't know why the rest of the settings are not written when
> > isOpen is written, but at least the patch solves the problem ...
> >
> > OK to commit ?


I see this got committed.

> I applied your patch locally in my sandbox and it seems to work for
> me. I changed a couple folder properties, then ran kill -TERM
> `pidof kontact` and when I restarted kontact the changed properties
> where still there.


And then reverted. 

"The previous commit was done too fast, as Ingo already fixed it
the right way ..."

But I guess if the bug is fixed then 115464 can be closed, no?

Don Sanders.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]