[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Palette in KFolderTree and subclasses
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2005-10-30 10:52:25
Message-ID: 200510301152.26201 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 30 October 2005 00:52, Andreas Gungl wrote:
> The palette handling in KFolderTree / KMFolderTree is all but
> friendly. In fact, I have to duplicate code for the color / palette
> handling between KMFolderTree and SimpleFolderTree to solve bug
> #115343.
> ( http://bugs.kde.org/show_bug.cgi?id=115343 )
>
> Please have a look at the attached patch which solves the bug. I
> would like to commit it to the 3.5 branch.

I think the lines
+  QColor c2=QColor("blue");
and
+  mPaintInfo.colUnread = c2;
are superfluous. Or is this color needed?

Otherwise the patch is okay although I don't think the temporary 
variables c1 and c4 have any purpose. (Coding style: readColorConfig() 
instead of readColorConfig (void) and a bit more whitespace in selected 
places.)

> However, I would prefer to 
> not simply forward port it to trunk, but to reconsider the complete
> KFolderTree class and its child classes. IIUC Qt4 will provide a 
> TreeView, which might be a better soltion for the folder tree problem
> (and which might simplify the color handling as well). So a complete
> re-engineering of the folder tree implementation might make sense.
> Certainly we should as well think about the distribution of the code
> between kmail (and related) and libkdepim.

I agree. But you should still forward port your fix to trunk. There is 
an awful lot of stuff that we should re-engineer in KMail and it's not 
very likely that we'll manage to finish this for KDE 4.0.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]