[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Re: Inconsistent handling of Ignored state
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2005-09-29 5:16:44
Message-ID: 200509290716.44922 () gungl-dd ! de
[Download RAW message or body]

Am Mittwoch, 28. September 2005 23:12 schrieb Ingo Klöcker:
> On Saturday 24 September 2005 20:44, Andreas Gungl wrote:
> > Am Samstag, 24. September 2005 14:06 schrieb Ingo Klöcker:
> > > On Saturday 24 September 2005 02:27, Andreas Gungl wrote:
> > > > Here we go for the 3.5 branch - please review.
> > >
> > > Looks pretty much like what I had in mind.
> > >
> > > > I've tested the
> > > > changes and found that the additional changes in isNew() and
> > > > isUnread() are necessary. BTW, I currently have no kdepim trunk
> > > > checkout laying around, so I could commit only to the branch.
> > >
> > > No problem. I'll forward-port it to.
> >
> > I've committed to the branch. Thanks for porting it.
>
> Thomas noticed a regression. If you ignore a thread then the unread
> count of the folder isn't updated correctly. A possible solution (a
> nasty hack?) would be to count the number of unread messages in the
> thread and then change the unread count of the folder accordingly.

Hm, I have to read through the sources before changing anything.

What I've found so far is distributed code for the same functionality like 
parsing the status of a message from the status string (in kmmsgbase and 
kmfoldermaildir.cpp:711). The culprit is then kmfoldermaildir.cpp:827 where 
the (re-defined by me) isRead() and friends aren't used at all, but the 
status enums are used directly.

Well, this screams for refactoring, but the question is how many places would 
I have to change (all folder types?) and how much time is left until I have 
to have done it.
I could do it until the weekend, is that okay for the 3.5 schedule? Or should 
we better revert and do such a change only in trunk?

Andreas
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]