[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 109836] Add Support for displaying Face: header
From:       Ingo "Klöcker" <kloecker () kde ! org>
Date:       2005-08-21 10:48:23
Message-ID: 20050821104823.24321.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=109836         
kloecker kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From kloecker kde org  2005-08-21 12:48 -------
On Saturday 20 August 2005 23:34, Nick Brown wrote:
> SVN commit 451500 by nickbroon:
>
> FEATURE: 109836
> Add Support for displaying Face: header


We are in feature freeze for KDE 3.5 and this feature is not among the 
features which are listed in the feature plan. I'm sorry, but you will 
have to revert your commit.

> +	    if ( TRUE == faceimage.loadFromData( facearray, "png" ) )


TRUE doesn't exist. If you mean the C++ key word "true" then you should 
have simply written 
+	    if ( faceimage.loadFromData( facearray, "png" ) )

Also I notice tabs in your patch. Usage of tabs is not allowed! 
Moreover, the opening '{' has to be on the same line a 'if ( ... )'. 
Please read http://korganizer.kde.org/develop/hacking.html for more 
information about the kdepim coding style.

Regards,
Ingo
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]