[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: PATCH: Make filters work for incoming IMAP messages
From:       Don Sanders <sanders () kde ! org>
Date:       2005-05-06 7:04:46
Message-ID: 200505061704.46524.sanders () kde ! org
[Download RAW message or body]

On Thursday 05 May 2005 18:41, Carsten Burghardt wrote:
> On Thursday 05 May 2005 09:24, Don Sanders wrote:
> > Okay. Well if you or anyone else finds a problem please let me
> > know, either here or in private mail is fine also. (Did anyone
> > try it?).
> >
> > I will go look at recent bug reports now. If I don't find
> > anything alarming I'll take a breather and then move onto the
> > next stage.
>
> I fixed a crash recently which was introduced by this patch. The
> crash doesn't occur anymore but I wonder where it comes from.

I'm a bit worried that the list of unfiltered mails that is now saved 
in the destructor could get garbage put in it. Perhaps it's just a 
single null entry or something the first time the system is used.

> The 
> folder of the incoming messages was not found.
>
> --- kdepim/kmail/kmacctimap.cpp  #1.196:1.197
> @@ -412,4 +412,9 @@ void KMAcctImap::postProcessNewMail( KMF
>      // It's possible that the message has been deleted or moved
> into a // different folder, or that the serNum is stale
> +    if ( !folder ) {
> +      mFilterSerNumsToSave.remove( QString( "%1" ).arg( *filterIt
> ) ); +      ++filterIt;
> +      continue;
> +    }

I see, sorry I missed that. Thank you.

Don Sanders
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]