[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Compress emits to gui.
From:       David Faure <dfaure () klaralvdalens-datakonsult ! se>
Date:       2005-04-15 8:34:52
Message-ID: 200504151034.53075.dfaure () klaralvdalens-datakonsult ! se
[Download RAW message or body]

On Friday 15 April 2005 01:42, Mario Teijeiro Otero wrote:
> Hi,
> 
> 	I am with dimap and my imap server reside on the lan. I notice that a 
> "Refresh cache" or a checking mail with a lot of new messages eat the 100% of 
> cpu.
> 	I found that the problems is related with the gui refresh, because the gui is 
> refreshed with each mail that arrives ( kmheaders, kmfoldertree and 
> statusBar ). With a suggestion of Till I compress the signals "msgAdded" in
> FolderStorage::emitMsgAddedSigals getting good results, I did the same with 
> the signal numUnreadMsgsChanged because this is connected with the refresh of 
> status bar. 

Can the timer be called something else that mQuietTimer? Too many things are
called "quiet" already in kmail's code IMHO - it's too generic a term.
If this timer is about emitting changed(), it should be mEmitChangedTimer.

Just my 2 cents for code readability.

-- 
David Faure -- faure@kde.org, dfaure@klaralvdalens-datakonsult.se
Qt/KDE/KOffice developer
Klarälvdalens Datakonsult AB, Platform-independent software solutions
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]