[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: kdepim/kmail
From:       Matt Douhan <matt () fruitsalad ! org>
Date:       2005-03-01 13:18:52
Message-ID: 200503011418.53541.matt () fruitsalad ! org
[Download RAW message or body]

On Tue March 1 2005 13:48, Matt Douhan wrote:
> On Tue March 1 2005 10:14, Tom Albers wrote:
> > I'm still learning of course, so please tell me if I'm wrong but this
> > part is not friendly for translators who have to deal with more then two
> > forms of plural.
> >
> > Maybe something like:
> > MessageBox::informationList( this,
> >  i18n( "This identity now uses the default transport:",
> >          "These %n identities now use the default transport:",
> >   changedIdents.count() ), changedIdents);
>
> I don't get the difference, but if the end result is the same and it makes
> life easier for the translators I am all for the change.
>
> I still see 2 strings that needs translating, and the previous code also
> had 2 strings, normally this means I am missing something so please tell me
> why the latter is easier for translators
>

OK after some explanation on irc I do get the difference, I am attaching a new 
patch to correct this.

OK to commit?

rgds

Matt


-- 
Matt Douhan
www.fruitsalad.org
kolab2 + kontact == success

["patch_configuredialog_cpp" (text/x-diff)]

Index: configuredialog.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/configuredialog.cpp,v
retrieving revision 1.522
diff -u -3 -p -r1.522 configuredialog.cpp
--- configuredialog.cpp	1 Mar 2005 05:47:25 -0000	1.522
+++ configuredialog.cpp	1 Mar 2005 13:16:49 -0000
@@ -870,12 +870,9 @@ void AccountsPage::SendingTab::slotRemov
 
   // this part cannot be backported to BRANCH since it holds new strings
   if ( !changedIdents.isEmpty() ) {
-    QString information;
-    if ( changedIdents.count() > 1 ) {
-      information = i18n( "These identitites have been changed to use the default transport:" );
-    } else {
-      information = i18n( "This identity has been changed to use the default transport:" );
-    }
+    QString information = i18n( "This identity has been changed to use the default transport:",
+                          "These %n identitites have been changed to use the default transport:",
+                          changedIdents.count() );
     KMessageBox::informationList( this, information, changedIdents );
   }
 


_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]