[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    two small patches
From:       Aaron Seigo <aseigo () kde ! org>
Date:       2005-02-28 19:50:28
Message-ID: 200502281250.28933.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


hi all..

attached is a diff for two small patches:

0. make the border around the presence information use mid() instead of the 
foreground colour. currently it has a "box in box" visual effect that's less 
pleasing IMHO.

1. change the icon from refresh to mail_get for the "Check mail in this 
folder" item in the folder context menu. right now there are _two_ refresh 
icons (which means one can't just rely on the icon for identification, one 
needs to read), and since it says "Check mail" (even though it does actually 
refresh, technically) it makes sense IMHO to sync this icon with the other 
appearances of "Check mail in" actions in kmail.

neither are major issues, but thought i'd pass them by you people =)

-- 
Aaron J. Seigo
Society is Geometric

["kmail_various.diff" (text/x-diff)]

Index: csshelper.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/csshelper.cpp,v
retrieving revision 1.19
diff -u -3 -d -p -r1.19 csshelper.cpp
--- csshelper.cpp	20 Feb 2005 20:17:50 -0000	1.19
+++ csshelper.cpp	28 Feb 2005 19:36:53 -0000
@@ -408,7 +408,7 @@ namespace KMail {
 
                "div.senderpic{\n"
                "  font-size:0.8em ! important;\n"
-               "  border:1px solid black ! important;\n"
+               "  border:1px solid %4 ! important;\n"
                "  background-color:%2 ! important;\n"
                "}\n\n"
 
@@ -418,7 +418,8 @@ namespace KMail {
             )
       .arg( headerFont,
             cg.background().name(),
-            cg.foreground().name() )
+            cg.foreground().name(),
+            cg.mid().name())
       + quoteCSS;
   }
 
Index: kmmainwidget.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/kmmainwidget.cpp,v
retrieving revision 1.321
diff -u -3 -d -p -r1.321 kmmainwidget.cpp
--- kmmainwidget.cpp	26 Feb 2005 01:20:32 -0000	1.321
+++ kmmainwidget.cpp	28 Feb 2005 19:36:54 -0000
@@ -2297,7 +2297,7 @@ void KMMainWidget::setupActions()
   mCompactFolderAction = new KAction( i18n("&Compact Folder"), 0, this,
 		      SLOT(slotCompactFolder()), actionCollection(), "compact" );
 
-  mRefreshFolderAction = new KAction( i18n("Check Mail &in This Folder"), "reload",
+  mRefreshFolderAction = new KAction( i18n("Check Mail &in This Folder"), "mail_get",
                                       KStdAccel::shortcut( KStdAccel::Reload ), this,
                                       SLOT(slotRefreshFolder()),
                                       actionCollection(), "refresh_folder" );

[Attachment #8 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]