[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Patch for BUG:88367
From:       Ingo =?utf-8?q?Kl=C3=B6cker?= <kloecker () kde ! org>
Date:       2005-02-27 21:49:31
Message-ID: 200502272249.37741 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Sunday 27 February 2005 21:20, Matt Douhan wrote:
> +  if ( !changedIdents.isEmpty() ) {
> +    QString changedIdentsString = changedIdents.join( ", " );
> +    QString information;
> +    int commaCount = changedIdentsString.contains( ',' );

Use changedIdents.count() instead of counting commas.

> +    if ( commaCount > 0 ) {
> +      information = i18n( "These identitites have been changed to
> use the default transport" ); +    } else {
> +      information = i18n( "This identity have been changed to use
> the default transport" ); +    }

typo: "This identity _has_ been changed ..."

> +    QString infoMsg( "<qt><p><b>" + changedIdentsString +
> +                     "</b></p><p>" + information +
> +                     "</p></qt>" );
> +    KMessageBox::information( this, infoMsg, i18n("Identitychanges")
> ); +  }

I propose to use
  KMessageBox::informationList( this, information, changedIdents );

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]