[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 87417] Choosing threading for a folder before folder is
From:       Till Adam <adam () kde ! org>
Date:       2005-01-01 18:45:02
Message-ID: 20050101184502.8238.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=87417        
adam kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From adam kde org  2005-01-01 19:45 -------
CVS commit by tilladam: 

Make sure the actions pertaining to the headers list and the readerwindow
are only active when those contain something.

BUG: 87417


  M +7 -4      kmmainwidget.cpp   1.304


--- kdepim/kmail/kmmainwidget.cpp  #1.303:1.304
 @ -1639,4 +1639,5  @ void KMMainWidget::folderSelected()
 {
   folderSelected( mFolder );
+  updateFolderMenu();
   // opened() before the getAndCheckFolder() in folderSelected
   if ( mFolder && mFolder->folderType() == KMFolderTypeImap )
 @ -1695,4 +1696,5  @ void KMMainWidget::folderSelected( KMFol
       imap->getAndCheckFolder();
       mHeaders->setFolder( 0 );
+      updateFolderMenu();
       mForceJumpToUnread = forceJumpToUnread;
       return;
 @ -3013,7 +3015,8  @ void KMMainWidget::updateFolderMenu()
   mExpireFolderAction->setEnabled( mFolder && mFolder->isAutoExpire() );
   updateMarkAsReadAction();
-  mPreferHtmlAction->setEnabled( mFolder ? true : false );
-  mPreferHtmlLoadExtAction->setEnabled( mFolder && (mHtmlPref ? !mFolderHtmlPref : \
                mFolderHtmlPref) ? true : false );
-  mThreadMessagesAction->setEnabled( mFolder ? true : false );
+  // the visual ones only make sense if we are showing a message list
+  mPreferHtmlAction->setEnabled( mHeaders->folder() ? true : false );
+  mPreferHtmlLoadExtAction->setEnabled( mHeaders->folder() && (mHtmlPref ? \
!mFolderHtmlPref : mFolderHtmlPref) ? true : false ); +  \
mThreadMessagesAction->setEnabled( mHeaders->folder() ? true : false );  
   mPreferHtmlAction->setChecked( mHtmlPref ? !mFolderHtmlPref : mFolderHtmlPref );
 @ -3022,5 +3025,5  @ void KMMainWidget::updateFolderMenu()
       mThreadPref ? !mFolderThreadPref : mFolderThreadPref );
   mThreadBySubjectAction->setEnabled(
-      mFolder ? ( mThreadMessagesAction->isChecked()) : false );
+      mHeaders->folder() ? ( mThreadMessagesAction->isChecked()) : false );
   mThreadBySubjectAction->setChecked( mFolderThreadSubjPref );
 }
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]