[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Patch] Wallet support for KMail
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-08-27 16:24:05
Message-ID: 200408271824.12168 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 27 August 2004 16:52, Volker Krause wrote:
> On Friday 27 August 2004 15:53, Bo Thorsen wrote:
> > On Friday 27 August 2004 15:34, Volker Krause wrote:
> > > On Friday 27 August 2004 14:27, David Faure wrote:
> > > > If yes, then the method can also be made const.
> > >
> > > No, since passwd() loads the password from the wallet on first
> > > use.
> >
> > Nitpicking: Declare mWallet mutable, and then you can make passwd()
> > const. It's The Right Way (TM).
>
> new version of the patch attached.

Apart from a few coding style issues, e.g.
+  for (QPtrListIterator<KMAccount> it(mAcctList); it.current(); ++it) {
should be
+  for ( QPtrListIterator<KMAccount> it( mAcctList ); it.current(); ++it ) {
the patch is now ready for being committed.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]