[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Patch] Wallet support for KMail
From:       Bo Thorsen <bo () sonofthor ! dk>
Date:       2004-08-27 13:53:13
Message-ID: 200408271553.19427.bo () sonofthor ! dk
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 27 August 2004 15:34, Volker Krause wrote:
> On Friday 27 August 2004 14:27, David Faure wrote:
> > Just a tiny nitpick:
> > +  /** Get/set password for this account */
> > +  QString& passwd();
> > +  void setPasswd( const QString& passwd );
> >
> > Isn't the & too much in the passwd() line?
>
> Yes, of course. Thanks for reviewing, this just pointed me to another
> bug :)
>
> > If yes, then the method can also be made const.
>
> No, since passwd() loads the password from the wallet on first use.

Nitpicking: Declare mWallet mutable, and then you can make passwd() const. 
It's The Right Way (TM).

Other than that, I applaud the patch :-) I'm looking forward to the day we 
have single sign on in KDE.

Bo.

-- 

     Bo Thorsen                 |   Praestevejen 4
     Senior Software Engineer   |   5290 Marslev
     Klarälvdalens Datakonsult  |   Denmark

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]