[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [Patch] Wallet support for KMail
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-08-26 22:33:01
Message-ID: 200408270033.12372 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Thursday 26 August 2004 23:34, Volker Krause wrote:
> Hi,
>
> took a bit longer than I had expected but here it is finally: Wallet
> support for mail accounts and SMTP servers.
>
> Mail accounts work as expected (as few as possible wallet password
> dialogs), the code is mostly taken from KNode.
>
> SMTP servers are a bit different: First they don't have a unique id
> which is needed for the wallet, I added unique id's by coping the
> corresponding code from the account manager. Second they are read
> from the config file on demand instead of kept in memory. This makes
> password caching impossible, ie. the wallet needs to be accessed for
> every send message (which will result in a new wallet password dialog
> if the wallet has been closed in the meantime).
>
> One thing that might be sub-optimal is the location of the static
> wallet pointer and the wallet opening method in KAcctMgr, since a) it
> is not account specific and also accessed by the KMTransport code and
> b) I didn't found a way to access the winID of the toplevel widget
> from there. I guess you might know a better place for this code ;)

A better place for the static is probably the kernel (kmkernel.cpp). The 
kernel should also know the appropriate winId. We have 
KMKernel::mainWin() which can be used.

> Beside the issues mentioned above the code works so far, including
> migration from the config file to KWallet.

Great. Thanks for your work.

> BTW: Where is the difference between
> KMTransportInfo::availableTransports() and
> TransportManager::transportNames()?

Apparently both do the same, but TransportManager is IMO a much better 
place for this method. Most likely I overlooked 
KMTransportInfo::availableTransports() and therefore re-invented it in 
TransportManager.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]