[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: ad-hoc filter preview pane problem
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2004-07-31 19:45:25
Message-ID: 200407312145.27671 () gungl-dd ! de
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Freitag, 30. Juli 2004 10:18, Till Adam wrote:
> On Friday 30 July 2004 09:29, Don Sanders wrote:
> > On Friday 30 July 2004 00:49, Andreas Gungl wrote:
> > > Hi,
> > >
> > > as long as ad-hoc filters exist we have the problem described in
> > > http://bugs.kde.org/show_bug.cgi?id=75517 which is getting quite
> > > serious as we roll out the anti spam wizard. The wizard generates
> > > ad-hoc filters and creates toolbar buttons to access these filters.
> > >
> > > Don, you introduced the ad-hoc filters. Do you see a way to fix the
> > > problem until 3.3? I can try to help if you can provide me an idea
> > > about what might be the reason for the problem or where to start
> > > analyzing.
> >
> > Maybe this is a simple regression, something like the attached patch
> > might fix it ok.
>
> Looks good to me. KMHeaders::applyFiltersOnMsg() seems to duplicate that
> code. The commented out actionscheduler version above uses it, though. I
> guess it could use it as well?
>
> Till

I've put the code inside the ifdef, IMO one can understand it better this 
way. I bet async filtering is one of the next features after the freeze, so 
that code will undergo reconstruction anyway.
I'm really happy this is fixed for 3.3.

Andreas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBC/bVVhjiFd4beU8RAkVSAKD+PsuNjYHmQAPozTMxwjarh0KlzQCgsCsh
DwJjWpZVU2Y4uGSZkTEpp/Q=
=4bSV
-----END PGP SIGNATURE-----
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]