[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 80541] Sorting mails by attachment
From:       Till Adam <adam () kde ! org>
Date:       2004-07-31 13:47:18
Message-ID: 20040731134718.21080.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=80541      
adam kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From adam kde org  2004-07-31 15:47 -------
CVS commit by tilladam: 

Add "has attachment" to the list of stati to search for in the quick
search dropdown, but not in the normal search/filter dialog where it is
special cased.

CCMAIL: 84409-done bugs kde org
CCMAIL: 80541-done bugs kde org


  M +2 -0      kmsearchpattern.cpp   1.70
  M +3 -1      kmsearchpattern.h   1.26
  M +3 -3      rulewidgethandlermanager.cpp   1.11


--- kdepim/kmail/kmsearchpattern.cpp  #1.69:1.70
 @ -614,4 +614,6  @ KMMsgStatus KMSearchRuleStatus::statusFr
   if ( ! aStatusString.compare("ham") )
      status = KMMsgStatusHam;
+  if ( ! aStatusString.compare("has an attachment") )
+     status = KMMsgStatusHasAttach;
 
   return status;

--- kdepim/kmail/kmsearchpattern.h  #1.25:1.26
 @ -229,8 +229,10  @ namespace KMail {
     I18N_NOOP( "spam" ),
     I18N_NOOP( "ham" ),
-    I18N_NOOP( "todo" )
+    I18N_NOOP( "todo" ),
+    I18N_NOOP( "has an attachment")
   };
   static const int StatusValueCount =
     sizeof( StatusValues ) / sizeof( *StatusValues );
+  static const int StatusValueCountWithoutHidden = StatusValueCount - 1;
 }
 

--- kdepim/kmail/rulewidgethandlermanager.cpp  #1.10:1.11
 @ -1058,5 +1058,5  @ namespace {
     QComboBox *statusCombo = new QComboBox( valueStack,
                                             "statusRuleValueCombo" );
-    for ( int i = 0; i < KMail::StatusValueCount; ++i ) {
+    for ( int i = 0; i < KMail::StatusValueCountWithoutHidden; ++i ) {
       statusCombo->insertItem( i18n( KMail::StatusValues[i] ) );
     }
 @ -1218,5 +1218,5  @ namespace {
     const QString value = rule->contents();
     int valueIndex = 0;
-    for ( ; valueIndex < KMail::StatusValueCount; ++valueIndex )
+    for ( ; valueIndex < KMail::StatusValueCountWithoutHidden; ++valueIndex )
       if ( value == QString::fromLatin1(
                KMail::StatusValues[valueIndex] ) )
 @ -1227,5 +1227,5  @ namespace {
     if ( statusCombo ) {
       statusCombo->blockSignals( true );
-      if ( valueIndex < KMail::StatusValueCount )
+      if ( valueIndex < KMail::StatusValueCountWithoutHidden )
         statusCombo->setCurrentItem( valueIndex );
       else {
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]