[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Fix loose ends in crypto support: pt.4+5/??:
From:       Marc Mutz <mutz () kde ! org>
Date:       2004-05-31 15:31:42
Message-ID: 200405311731.42562.mutz () kde ! org
[Download RAW message or body]

On Monday 31 May 2004 17:05, Ingo Klöcker wrote:
> On Sunday 30 May 2004 21:23, Marc Mutz wrote:
<snip>
> So what happens if the user disables automatic import?

app/pkcs7-mime; smime-type=cert-only attachments are no longer imported 
automatically. This is the S/MIME equivalent of app/pgp-keys. Importing 
keys embedded in a S/MIME signature is the S/MIME equivalent of 
auto-key-retrieve. Both settings are out-of-domain for a MUA, while 
importing attached certs is in-domain for a MUA.

> The user's 
> wish is ignored (because gpgsm doesn't care for the user's wish
> anyway)?
<snip>

If you want to make it sound so dramatic, yes :)

> The patch is lacking some whitespace, e.g. between parentheses and
> their contents. (I know, not before the merge. But they should've
> been there in the first place.)
<snip>

I've not found any missing whitespace when just scanning the patch. If 
you mean SIGNAL(toggled(bool)), I consider this a special case, since 
the SIGNAL() is _one_ arg. (I also believe it reduces the amount of 
storage and the time needed to parse the signal spec when all 
superfluous whitespace is removed, since it's stringified by that 
macro).

The other one I found is i18n("foo"). I've got a habit of leaving the 
whitespace out of there, perhaps since the quotes make up for it 
somewhat. In some sense, it might even make more sense, since it's a 
more like a SIGNAL() than a function call, but don't get me started on 
finding an explanation for this. :)

Marc

-- 
History teaches that grave threats to liberty often come in times of
urgency, when constitutional rights seem too extravagant to endure.
                                  -- Justice Thurgood Marshall, 1989
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

[prev in list] [next in list] [prev in thread] [next in thread]