[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] button for resetting fontsettings in
From:       Ingo =?windows-1252?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-04-19 22:30:24
Message-ID: 200404200030.26167 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 19 April 2004 23:54, Edwin Schepers wrote:
> On Monday 19 April 2004 00:04 am, Ingo Klöcker wrote:
> > Please add diff -u3 -p
> > to your ~/.cvsrc file and then recreate and resend the diff.
>
> Of course, hereby...
> It also solves an issue that font-dropdownbox and buttons are not set
> when selecting the html-toolbar.

Shouldn't the following
+  mEditor->setColor(QColor(0,0,0));
be
+  mEditor->setColor(mForeColor);

After all the text color is configurable in KMail and there might be 
people who don't use black on white.

Please change "Reset current fontsettings" to "Reset Font Settings" (the 
"current" is superfluous and the GUI style guide requires 
capitalization).

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]