[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [PATCH] Reorder status icons
From:       Ingo =?iso-8859-15?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-02-29 19:38:09
Message-ID: 200402292038.10405 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Hi,

now that we have an attachment icon I noticed that the order of the 
status icons is IMO suboptimal. The attached patch makes the following 
changes:

- Show the attachment icon and the crypto icons directly after the 
primary message status icon (new, unread, read, delete [is delete 
actually a primary status icon?]) and before the secondary status icons 
(important, replied, forwarded).

- I also moved the Queued/Sent icon before the primary status icons. But 
I'm not sure about this.

This is open for discussion. I'd like to see at least the first change 
because this icon order makes IMO more sense then the current order.

Regards,
Ingo


["reorder-status-icons.diff" (text/x-diff)]

Index: kmheaders.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/kmheaders.cpp,v
retrieving revision 1.616
diff -u -3 -p -r1.616 kmheaders.cpp
--- kmheaders.cpp	26 Feb 2004 17:59:43 -0000	1.616
+++ kmheaders.cpp	26 Feb 2004 20:01:45 -0000
@@ -347,15 +347,18 @@ public:
       if(mMsgBase->isIgnored()) pixmaps << *KMHeaders::pixIgnored;
       if(mMsgBase->isWatched()) pixmaps << *KMHeaders::pixWatched;
 
+      if(mMsgBase->isQueued()) pixmaps << *KMHeaders::pixQueued;
+      if(mMsgBase->isSent()) pixmaps << *KMHeaders::pixSent;
+
       if(mMsgBase->isNew()) pixmaps << *KMHeaders::pixNew;
       if(mMsgBase->isRead() || mMsgBase->isOld()) pixmaps << *KMHeaders::pixRead;
       if(mMsgBase->isUnread()) pixmaps << *KMHeaders::pixUns;
       if(mMsgBase->isDeleted()) pixmaps << *KMHeaders::pixDel;
-      if(mMsgBase->isImportant()) pixmaps << *KMHeaders::pixFlag;
-      if(mMsgBase->isReplied()) pixmaps << *KMHeaders::pixRep;
-      if(mMsgBase->isForwarded()) pixmaps << *KMHeaders::pixFwd;
-      if(mMsgBase->isQueued()) pixmaps << *KMHeaders::pixQueued;
-      if(mMsgBase->isSent()) pixmaps << *KMHeaders::pixSent;
+
+      // Only merge the attachment icon in if that is configured.
+      if( headers->paintInfo()->showAttachmentIcon &&
+          mMsgBase->attachmentState() == KMMsgHasAttachment )
+        pixmaps << *KMHeaders::pixAttachment;
 
       // Only merge the crypto icons in if that is configured.
       if( headers->paintInfo()->showCryptoIcons ) {
@@ -377,15 +380,15 @@ public:
           else if( mMsgBase->signatureState() == KMMsgSignatureProblematic )
               pixmaps << *KMHeaders::pixSignatureProblematic;
       }
-      // Only merge the attachment icon in if that is configured.
-      if( headers->paintInfo()->showAttachmentIcon && 
-          mMsgBase->attachmentState() == KMMsgHasAttachment ) 
-        pixmaps << *KMHeaders::pixAttachment;
+
+      if(mMsgBase->isImportant()) pixmaps << *KMHeaders::pixFlag;
+      if(mMsgBase->isReplied()) pixmaps << *KMHeaders::pixRep;
+      if(mMsgBase->isForwarded()) pixmaps << *KMHeaders::pixFwd;
 
       static QPixmap mergedpix;
       mergedpix = pixmapMerge( pixmaps );
       return &mergedpix;
-    } 
+    }
     return 0;
   }
 

[Attachment #8 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]