[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] composing html messages
From:       Don Sanders <sanders () kde ! org>
Date:       2004-02-19 2:50:04
Message-ID: 200402191244.00242.sanders () kde ! org
[Download RAW message or body]

Hi Edwin,

Sorry for the delay,

On Thursday 12 February 2004 01:51, Edwin Schepers wrote:
> On Tuesday 10 February 2004 07:01, Don Sanders wrote:
> > On Sunday 08 February 2004 21:22, Edwin Schepers wrote:
> > > Hi,
> > > Finally it looks I have something workable.
> > > It's not final: indentation, deleting some kDebug's and naming
> > > has to be changed.
> > > Could you (someone) review ?
> > > If this is the way to go, and when it looks quite stable, can I
> > > commit (after the changes to make it final)?
> >
> > Great! The basic functionality of creating multipart/alternative
> > messages is working well now.
> >
> > I think just some relatively minor clean ups and the patch can go
> > in. Specifically removing the DEBUG define and commented out
> > code, disabling the html toolbar by default and if possible
> > resolving the too large line spacing issue and the patch should
> > be ok.
>
> Hi Don,
> This is a new patch.
> - #define DEBUG deleted
> - messagebox when trying to sign/encrypt HTML messages
> - code cleanup
> - html toolbar off by default

Cool.

> Issues to be solved :
> - line spacing when opening and closing from Drafts

I'm having difficulty reproducing this now. Not sure if that's a good 
thing (it's fixed?) or a bad thing (just hard to reproduce?).

> - signing/encryption of HTML messages

I think traditional GnuPG Signing/Encrypting doesn't make sense for 
HTML mails. Because there is no significant body part, HTML mails 
only consist of alternative attachments, (and traditional GnuPG 
signing/encryption doesn't support encrypting/signing attachments).

I think if KMail is configured for traditional GnuPG support then 
signing/encryption should be completely disabled, anything else would 
be dangerous and a security flaw.

S/MIME support should be possible, but it doesn't seem to make sense 
working on that now with the S/MIME code being modified in the 
aegypten_branch and pending merging.

> - opening HTML messages from Drafts does not always show a correct
> message (it's including the HTML code). This has to do with the
> fact that the bodyParts are not always the same. It seems that it
> differs depending of whether another message is clicked before.

I can reproduce this. I'll try to find to look at it but please let me 
know if you fix it first, I'll do the same.

> I hope these issues won't stop my patch going into cvs.

Ingo, Cornelius I'd appreciate a comment on the S/MIME 
signing/encryption and HTML editing situation. Wait for the aegypten 
merge or commit before? 

Don.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]