[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] composing html messages
From:       Don Sanders <sanders () kde ! org>
Date:       2004-01-28 10:02:20
Message-ID: 200401282002.20529.sanders () kde ! org
[Download RAW message or body]

Hi,

On Tuesday 27 January 2004 05:33, Edwin Schepers wrote:
> Hi,
> This is a first rough patch for composing html messages. Could
> someone review it ?

Yes I am reviewing it now. I have some initial remarks but it will 
take me a few days to properly review the patch.

In kmcomposewin.cpp I think the
#include <kcoloractions.h>
is unnecessary, and undesirable as this seems to be a koffice include 
file.

I think the kmcomposerui.rc file needs to have the kpartgui version 
number incremented, I didn't see the html toolbar until I did this.

> behaviour is :
> - Composing a new mail : default always starting in plaintext. when
> some markup is selected, the mail becomes multipart/altenative.

I guess that's ok for now. Other core developers might have opinions 
on that.

> - 
> Spellchecking : on "cancel", the original text is not set. only the
> spellchecking dialog disappears.

I'm having trouble reproducing this behavior. The spellchecking is 
reverting the text when I click cancel as I would expect. 

Maybe I'm missing something. The non as-you-type spell checker is 
working well here :)

> - With a menu option "Editor" in the "options" menu, one can
> explicitly choose the type. here, richtext can be set back to
> plaintext.

For some reason I'm not getting an editor menu appearing even though I 
can see it in the kmcomposerui.rc file. I feel a checkable "html" 
menu item in the options menu would be better style.

> - in "Settings"->"Toolbars", the HTML toolbar can be choosen

Verified. Works well.

> Automatic Spellchecking on RichText is not possible, since
> QSyntaxHighlighter doesn't supprt this.

I will have a look into this problem myself.

> TODO :
> - more \n cq. <p></p> appear in the message after repeatedly
> opening and saving from drafts
>
> - spacing between lines is much more when first started with
> selecting for example the bold-button than when selecting all text
> and then selecting bold. Is this a QTextEdit issue which cannot be
> solved easily?

I can't reproduce this either. Can you make a small screenshot?

> - boundaries dissapear after setMultiPartBody() .Could someone help
> me with this one ? The boundaries are set, but it seems
> setMultiPartBody() deletes them again. Maybe with a reason but I
> don't know. (kmail however doesn't have a problem showing the
> message)
> Debug info from a test :
> KMComposeWin::composeMessage():

I'll need some more time before I can give a useful reply to this.

Don.
_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel
[prev in list] [next in list] [prev in thread] [next in thread]