[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] fix calls to deprecated methods of KABC::Addressbook
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2004-01-01 14:13:46
Message-ID: 200401011513.47341 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday 31 December 2003 22:03, Andreas Gungl wrote:
> On Mittwoch, 31. Dezember 2003 18:43, Cornelius Schumacher wrote:
> > On Wednesday 31 December 2003 16:37, Andreas Gungl wrote:
> > > On Mittwoch, 31. Dezember 2003 15:34, Cornelius Schumacher wrote:
> > > > If the save fails the caller has to release the ticket.
> > >
> > >     /**
> > >       Saves all addressees of one resource synchronously. If the
> > > save is successfull the ticket is deleted.
> > >
> > >       @param ticket The ticket returned by requestSaveTicket().
> > >       @return Whether the saving was successfully.
> > >      */
> > >     bool save( Ticket *ticket );
> > >
> > > I'll changed that, but please update the documentation in
> > > addressbook.h to reflect that demand.
> >
> > What is missing? "If the save is successfull the ticket is deleted"
> > is equivalent to "If the save fails the caller has to release the
> > ticket", isn't it?
>
> Well, applying boolean logic to that, you're right.

No. He's wrong. "A => B" does _not_ imply "~A => ~B". So either the 
sentence has to be changed to
"If and only if the save is successful then the ticket is deleted."
or it has to be changed to the much easier understandable
"If the save is successful then the ticket is deleted. Otherwise the 
caller has to release the ticket with releaseSaveTicket()."

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]