--===============1915617520==
Content-Type: multipart/signed; protocol="application/pgp-signature";
	micalg=pgp-sha1; boundary="Boundary-02=_1dd8/FK+0aDolEL";
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit


--Boundary-02=_1dd8/FK+0aDolEL
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Tuesday 30 December 2003 18:25, Ingo Kl=F6cker wrote:
> On Tuesday 30 December 2003 14:18, Till Adam wrote:
> > - =A0 =A0if (message()->isNew() || message()->isUnread() ||
> > message()->isRead()) - =A0 =A0 =A0message()->setStatus(KMMsgStatusRead);
> > + =A0 =A0SerNumList serNums;
> > + =A0 =A0if (message()->isNew() || message()->isUnread()) {
> > + =A0 =A0 =A0serNums.append( message()->getMsgSerNum() );
> > + =A0 =A0}
> > +
> > + =A0 =A0KMCommand *command =3D new KMSetStatusCommand( KMMsgStatusRead,
> > serNums ); + =A0 =A0command->start();
>
> I guess it doesn't make much sense to call the KMSetStatusCommand with
> an empty list of serial numbers. So the command should be moved into the
> if-branch.

Ok. Changed.

> > =A0 =A0 =A0if ( message()->isNew() || message()->isUnread() ) {
> > =A0 =A0 =A0 =A0KMMessage * receipt =3D message()->createMDN( MDN::Manua=
lAction,
> > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0MDN::Displayed,
> > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 =
=A0true /* allow GUI */ );
> > + =A0 =A0 =A0 =A0MDN::Displayed, true /* allow GUI */ );
>
> This indentation doesn't look right.

Ok. Changed.

> About the change in kio_imap. It would be nicer if it would be possible
> to use BODY and BODY.PEEK (depending on the situation). Isn't it
> possible to extend the IMAP slave accordingly? Then no apps that rely on
> the current behavior would break.

Hm. I kind of think it is really a bugfix, as the old behavior was arguably=
=20
more of a nasty side effect than intended behavior. Maybe you are right,=20
though. Carsten, any idea on how you want that done? Do you agree with Ingo?

Till

--Boundary-02=_1dd8/FK+0aDolEL
Content-Type: application/pgp-signature
Content-Description: signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQA/8dd1trsWGirveVsRAm4qAKDSRrXGWcNBVZP2tJbqcMLdVWcSJACg3vh/
eWGKmbBnXtKL1q3AaMHNKPE=
=2+t7
-----END PGP SIGNATURE-----

--Boundary-02=_1dd8/FK+0aDolEL--


--===============1915617520==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel

--===============1915617520==--