[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Fix for #70389 - VCards are sometimes empty because
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-12-30 11:25:22
Message-ID: 200312301225.31068 () erwin ! ingo-kloecker ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday 30 December 2003 11:28, Andreas Gungl wrote:
> Hi again,
>
> this patch fixes all issues (known to me) for #70389. It's an
> improvement to my patch from yesterday evening.
>
> As I understood a cvs comment from Marc in vcardviewer.cpp there will
> be at least one other place in the sources where the parsing is done
> in the old fashion way too. I'll try to find it and changed it to the
> working way too.
>
> Please review.

I didn't check the rest of KMail::VCardViewer::VCardViewer, but I guess 
VCardConverter isn't used anymore, so any references to it can be 
removed. It's anyway deprecated according to Tobias.

Apart from that the patch is okay.

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]