[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [PATCH] partial fix for #70389
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2003-12-29 21:08:00
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The attached patch fixes at least two issues of the report. It makes the 
dialog non-modal and it disables the Import button after an import instead 
of to hide it.
The actual problem with the vcard parsing can't get solved in KMail, it has 
to be done in kdelibs/kabc in the vcard parsing code.

Please review.

Andreas
- -- 
    ~
  ' v '
 //   \\
/(     )\  Powered by Penguin.
  ^ ' ^

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/8Je3VhjiFd4beU8RAi4iAKDNxiSZ5243qqSt2gHOy1EEFDKRjACgnbD1
Ocj5W9dmu8iesc1tLIyPNbw=
=sIYD
-----END PGP SIGNATURE-----

["vcardviewer.cpp.diff" (text/x-diff)]

Index: vcardviewer.cpp
===================================================================
RCS file: /home/kde/kdepim/kmail/vcardviewer.cpp,v
retrieving revision 1.3
diff -u -3 -p -r1.3 vcardviewer.cpp
--- vcardviewer.cpp	8 Jul 2003 19:31:29 -0000	1.3
+++ vcardviewer.cpp	29 Dec 2003 20:57:45 -0000
@@ -32,8 +32,10 @@ using KABC::Addressee;
 
 #include <qstring.h>
 
+// FIXME The title should be "VCard Viewer" instead of "VCard viewer",
+// can't change now because of KDE 3.2 string freeze
 KMail::VCardViewer::VCardViewer(QWidget *parent, const QString& vCard, const char* name)
-  : KDialogBase( parent, name, true, i18n("VCard viewer"), User1|Close, Close,
+  : KDialogBase( parent, name, false, i18n("VCard viewer"), User1|Close, Close,
 		 true, i18n("&Import"))
 {
   mAddresseeView = new AddresseeView(this);
@@ -66,7 +68,7 @@ KMail::VCardViewer::~VCardViewer()
 void KMail::VCardViewer::slotUser1()
 {
   if (KMAddrBookExternal::addVCard(mAddresseeView->addressee(), this))
-    showButton(User1, false);
+    enableButton(User1, false);
 }
 
 #include "vcardviewer.moc"


_______________________________________________
KMail developers mailing list
KMail-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmail-devel


[prev in list] [next in list] [prev in thread] [next in thread]