[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    [Bug 50841] data loss setting mail receiving location and
From:       Till Adam <adam () kde ! org>
Date:       2003-11-29 20:10:26
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
     
http://bugs.kde.org/show_bug.cgi?id=50841     
adam@kde.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From adam@kde.org  2003-11-29 21:10 -------
Subject: kdepim/kmail

CVS commit by tilladam: 

Don't allow users to specify the folder itself as the target folder of a maildir \
acccount. Since we are in string freeze this simply sets the target folder to the \
main inbox. After 3.2 we should pop up a dialog asking the user to select a different \
one.   
CCMAIL: 50841-done@bugs.kde.org 


  M +13 -5     accountdialog.cpp   1.134


--- kdepim/kmail/accountdialog.cpp  #1.133:1.134
@@ -1496,4 +1496,15 @@ void AccountDialog::saveSettings()
       mAccount->setName( mMaildir.nameEdit->text() );
       acctMaildir->setLocation( mMaildir.locationEdit->currentText() );
+      
+        KMFolder *targetFolder = \
*mFolderList.at(mMaildir.folderCombo->currentItem()); +        if ( \
targetFolder->location()  == acctMaildir->location() ) { +            /* 
+               Prevent data loss if the user sets the destination folder to be the \
same as the +               source account maildir folder by setting the target \
folder to the inbox.  +               ### FIXME post 3.2: show dialog and let the \
user chose another target folder +            */
+            targetFolder = kmkernel->inboxFolder();
+        }
+        mAccount->setFolder( targetFolder );
     }
     mAccount->setCheckInterval( mMaildir.intervalCheck->isChecked() ?
@@ -1505,7 +1516,4 @@ void AccountDialog::saveSettings()
 
     mAccount->setPrecommand( mMaildir.precommand->text() );
-
-    mAccount->setFolder( *mFolderList.at(mMaildir.folderCombo->currentItem()) );
-
   }
_______________________________________________
KMail Developers mailing list
kmail@kde.org
https://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]