[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] Improved Reply-All behaviour
From:       Ingo =?iso-8859-1?q?Kl=F6cker?= <kloecker () kde ! org>
Date:       2003-09-12 21:41:13
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 12 September 2003 02:56, Dirk Mueller wrote:
> +// -*- c-basic-offset: 2 -*-

Is this really necessary? Is there a less intrusive way to add this 
line, e. g. at the end of the file?

> @@ -1021,10 +1022,14 @@ KMMessage* KMMessage::createReply( bool
>        if( !mailingListPostAddress.isEmpty() )
>          recipients = stripAddressFromAddressList(
> mailingListPostAddress, recipients ); }
>  
> +    // if it is a mailing list, add the posting address
> +    if ( !mailingListPostAddress.isEmpty() )
> +      recipients += mailingListPostAddress;

This leads to duplicate messages for all KDE mailing-lists in case the 
user configured the mailing-list post address to be kmail@kde.org while 
the sender (like you) has sent the message to kmail@mail.kde.org. When 
replying-all KMail will put the user-specified mailing-list post 
address in To: and the other mailing-list address in Cc:.

I don't see a way to fix this problem (without resorting to your 
original proposal which would put only the sender's address in the To 
field, but not the mailing-list address). Note that in the current 
implementation this problem doesn't occur because we don't add the 
mailing-list post address explicitely to the list of recipients. Since 
it's already added implicitely during a reply-all (because it occured 
either in the To or the Cc header [ignoring the case were the mailing 
list was bcc'ed]) adding it explicitely is at most superfluous and at 
worst plainly wrong (as in the aforementioned case).

Regards,
Ingo

[Attachment #5 (application/pgp-signature)]

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail


[prev in list] [next in list] [prev in thread] [next in thread]