--===============23933497087960998== Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_ywRW/Q7Pd+apIR4"; charset="iso-8859-1" Content-Transfer-Encoding: 7bit --Boundary-02=_ywRW/Q7Pd+apIR4 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Description: signed data Content-Disposition: inline Am Dienstag, 2. September 2003 22:03 schrieb Aaron J. Seigo: > On Friday 29 August 2003 05:28, Klas Kalass wrote: > > I made a patch to make the visible header fields in the reader > > configurable. The patch is attached and screenshots can be found at > > http://www.kalass.de/kmail/index.html > > i just compiled it and have tried it out... i haven't looked at the code = in > detail yet (just skimmed through it), so i won't comment on that (yet =3D) > ... > > first, this is great ... i think it makes a lot of sense as a mechanism .= =2E. > personally, i'd propose that this feature (which is on the feature list, > btw) is polished up and the other header styles removed from the code as > they are then unecessary ... this would get rid of the View -> Headers > submenu as an extra bonus... i think there's a comment in your patch to a > similar affect =3D) thanks :-) > > some comments on the interface: > > "More..." should perhaps be "More headers..." and aligned with the header > data rather than the header titles, e.g.: > > Date: 2003 05:28:31 > More headers... What is the general opinion on this? I will change it when there is a=20 consensus. > > the checkbox icon for adding a header isn't very intuitive, as you noted. > using some simple text such as "Always show: " might help... or perhaps > have that as a header and use checkboxes to mark which ones to always show > (don't know how easy / possible it is to use form elements in the > readerwin, though)... > > "go back" is a bit misleading, since one isn't really "going back" =3D) if > one uses "More headers..." then perhaps "go back" could become "Fewer > headers..." or "Less headers..." or "Collapse headers..." Well, blame Ralf Nolden for that - Originally I had simply "less" and he=20 complained about it, so I changed it to "go back" to make him happy. Personally I don't care, as long as I get reasonably backed arguments I wil= l=20 change it to anything ;-) > > also, it seems just by looking at it in usage that it redisplays the whole > email whenever a header edit link is clicked (via a call to updateReaderw= in > ()) ... perhaps it would be better to provide a named div in the headers > area and simply edit that section of the HTML directly, allowing KHTML to > just rerender that section rather than the whole readerwindow. this would > decrease flicker, increase responsiveness and make a huge difference if y= ou > have a large attachment being viewed inline or some other part of the mail > display process requires a lot of processing... I am not sure if that is possible - I think I would need to alter the dom t= ree=20 which is displayed by khtml for that, don't I? I don't have the code here a= t=20 the moment so I don't know if I could access it without doing hacks. At N7H I got positive feedback from Don, Ingo, Till and Zack, but I would=20 especially like to hear comments from Marc because my code is based on his= =20 work - so what do you think, Marc? PS: please CC me - I don't always have the time to go through the ML --Boundary-02=_ywRW/Q7Pd+apIR4 Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) iD8DBQA/WRwyyPp3mvWRmvgRAsrzAJ9OqLorzsNI+wFBU+bx0PJ0m0fMggCgg7u4 2gpV5C3ylScCzYntyxkFzf4= =oZH5 -----END PGP SIGNATURE----- --Boundary-02=_ywRW/Q7Pd+apIR4-- --===============23933497087960998== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KMail Developers mailing list kmail@mail.kde.org http://mail.kde.org/mailman/listinfo/kmail --===============23933497087960998==--