-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 29 August 2003 05:28, Klas Kalass wrote:
> I made a patch to make the visible header fields in the reader
> configurable. The patch is attached and screenshots can be found at
> http://www.kalass.de/kmail/index.html

i just compiled it and have tried it out... i haven't looked at the code in 
detail yet (just skimmed through it), so i won't comment on that (yet =) ...

first, this is great ... i think it makes a lot of sense as a mechanism ... 
personally, i'd propose that this feature (which is on the feature list, btw) 
is polished up and the other header styles removed from the code as they are 
then unecessary ... this would get rid of the View -> Headers submenu as an 
extra bonus... i think there's a comment in your patch to a similar affect =)

some comments on the interface:

"More..." should perhaps be "More headers..." and aligned with the header data 
rather than the header titles, e.g.:

Date: 2003 05:28:31
       More headers...

the checkbox icon for adding a header isn't very intuitive, as you noted. 
using some simple text such as "Always show: " might help... or perhaps have 
that as a header and use checkboxes to mark which ones to always show (don't 
know how easy / possible it is to use form elements in the readerwin, 
though)...

"go back" is a bit misleading, since one isn't really "going back" =) if one 
uses "More headers..." then perhaps "go back" could become "Fewer headers..."  
or "Less headers..." or "Collapse headers..."

also, it seems just by looking at it in usage that it redisplays the whole 
email whenever a header edit link is clicked (via a call to updateReaderwin
()) ... perhaps it would be better to provide a named div in the headers area 
and simply edit that section of the HTML directly, allowing KHTML to just 
rerender that section rather than the whole readerwindow. this would decrease 
flicker, increase responsiveness and make a huge difference if you have a 
large attachment being viewed inline or some other part of the mail display 
process requires a lot of processing...

- -- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/VPeO1rcusafx20MRAtl4AJ9haC2wUimFcbOjiR2HqMPl/fP8YgCeM3lt
dGDWB7huQFn8WGdZiLu/Iik=
=dy4R
-----END PGP SIGNATURE-----
_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail