[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: [PATCH] ClientInterface (next try)
From:       Andreas Gungl <a.gungl () gmx ! de>
Date:       2003-07-27 20:03:13
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 27 July 2003 00:19, Cornelius Schumacher wrote:
> On Sunday 27 July 2003 00:16, Andreas Gungl wrote:
> > Any comments, hints and whatever are welcome as everytime.
>
> Just a little nitpicking, I can't comment on the content of the patch,
> because I didn't really look at it:

Thanks, you're right. Those things may be minor details in the beginning, 
but they are important the longer a software lives. So I've already changed 
it in my local copy.

Andreas

> - Instead of naming the class "KMailClient" it might be better to name
> it "Client" and put it into the "KMail" namespace. This has the same
> effect, but makes the code a little bit clearer inside of KMail.
>
> - The include guard should better be "#define KMAIL_CLIENT_H" instead of
> "#define CLIENT_H". Chances that KMail sometimes includes another
> CLIENT_H somewhere aren't high but probably above zero.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux)

iD8DBQE/JDAJVhjiFd4beU8RAsXDAKDb69Y06FRo0IuUnvdnViJ7wWnoYACg+aP8
DXBbuD2Cb3B0YuPghxUpRDA=
=ARKZ
-----END PGP SIGNATURE-----

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail

[prev in list] [next in list] [prev in thread] [next in thread]