[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kmail-devel
Subject:    Re: Implemented a new feature for KMail, please review
From:       Andreas Gungl <Andreas.Gungl () osp-dd ! de>
Date:       2003-07-17 4:44:05
[Download RAW message or body]

Hi Arnaud,

I like this feature from what your description is showing. I didn't went 
through your patch, so I cannot say something about the code. The issue I 
have is the usability of the "Take Addresses..." Dialog.

Having a column called Select and repeating "select" in each line isn't 
optimal. Also, I wouldn't create empty buttons but combine them with 
another info.
Nevertheless, I'm no specialist in GUI questions, I think / hope others will 
step in here to recommend further improvements.

Regards,
Andreas

Am Donnerstag, 17. Juli 2003 04:30 schrieb arnaud.burlet@epfl.ch:
> Hello,
>
> I implemented in KMail a way to take multiple email addresses from
> multiple messages and add them to the address book with only few mouse
> clicks...
>
> For an illustrated description please see
> http://www.realness.ch/~sts/kmail/
>
> The code is not yet finished, but as a total C++, QT, KDE, KMail newbie I
> need advices from other people. So can someone please review my work ?
> And talk back to me either on the list or privatly (I prefer privately
> not to flood the list with my questions ...).
>
> I will stop here for now, but of course I'll precise things when you ask
> it.
>
> I attach an archive with a diff against the kdepim repository, and my 2
> source files which should go in kmail sources directory.
>
> Arnaud
>
> PS: thanks Cornelius and Marc for your patient answers and comments

_______________________________________________
KMail Developers mailing list
kmail@mail.kde.org
http://mail.kde.org/mailman/listinfo/kmail
[prev in list] [next in list] [prev in thread] [next in thread]